Akash3121 commented on code in PR #10122:
URL: https://github.com/apache/paimon/pull/10122#discussion_r4078259035


##########
paimon-core/src/test/java/org/apache/paimon/index/FileIndexProcessorTest.java:
##########
@@ -174,4 +176,79 @@ public void testProcessReadsTheSchemasOfTheTableBranch() 
throws Exception {
         DataFileMeta processed = processor.process(entry.partition(), 
entry.bucket(), entry);
         assertThat(processed.extraFiles()).isNotEmpty();
     }
+
+    @Test
+    public void testRebuildsIndexOnCorrectColumnAfterColumnDropAndAdd() throws 
Exception {
+        LocalFileIO fileIO = LocalFileIO.create();
+        Path warehouse = new Path(tempDir.toString());
+        Map<String, String> options = new HashMap<>();
+        options.put(CoreOptions.BUCKET.key(), "1");
+        options.put(CoreOptions.FILE_FORMAT.key(), "parquet");
+        options.put(CoreOptions.FILE_INDEX + ".bloom-filter.columns", "v");

Review Comment:
   non blocking 
   Could this test use ` file-index.bitmap.columns`  instead of a Bloom filter? 
A Bloom-filter positive is probabilistic, so  `remain() == true ` does not 
strictly prove that  `100`  was indexed from  `v` ; a false positive could 
allow the old wrong-column behavior to pass. The bitmap index returns an exact 
empty result for an absent value, making this regression deterministic while 
preserving the same schema-evolution scenario.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to