JingsongLi commented on PR #10144: URL: https://github.com/apache/paimon/pull/10144#issuecomment-5805673497
Requirement fit: SUPPORTED. Flink currently leaves nested-row predicates to post-filtering, and reusing the existing nested transform has a credible end-to-end read-pruning benefit. Implementation: FINDINGS. [P1] Keep the new compatibility test on Java 8. `paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/NestedFieldReferencesTest.java:105` calls `ClassLoader.getPlatformClassLoader()`, which was introduced after Java 8. The Flink 1/JDK 8 test compilation fails with `cannot find symbol`; the PR's Flink 1 Common, Core JDK 8, licensing, and E2E CI jobs show the same error. Use a Java 8-compatible parent class loader while retaining the hidden-class test. This is a merge blocker for the supported JDK 8 build. Verification: the isolated JDK 8 reactor package build reproduces the compile failure. On JDK 17 the reactor package builds and the new reference/converter unit tests pass (18/18). The new Flink integration test could not start its MiniCluster locally because the BLOB Server could not bind a port; I could not independently verify actual scan pruning. The IT case checks result equality but does not assert that the real Flink plan supplied a nested predicate or that Paimon pruned reads, so please add a direct pushdown/pruning assertion before release. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
