JingsongLi commented on PR #10138: URL: https://github.com/apache/paimon/pull/10138#issuecomment-5805750889
This fixes a real resource-lifetime issue in the benchmark runner: `Files.list` owns a directory stream, and the new try-with-resources closes it after normal iteration and when YAML/file reading throws. The scope is small and the stream is not used after the block. Local verification on the isolated patch: the `paimon-cluster-benchmark` module compiled with JDK 8 and `-Pflink1` (including the normal compile checks). This module has no `src/test` tree, so I could not run an existing Sink test; the PR also adds no focused runtime regression for closing the stream on an exception. The fix has end-to-end value for repeated benchmark configuration loads, and I found no blocking code issue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
