JingsongLi commented on PR #10131: URL: https://github.com/apache/paimon/pull/10131#issuecomment-5805829317
The linked monitoring issue is a real end-to-end gap: table commit metrics available in Spark UI need to be scrapeable by JMX/Prometheus. I reviewed the shared registry, Spark source registration, V1 commit wiring, and metric replacement behavior. Replacing a key in the Codahale registry bounds MBean count across repeated commits for a given table/metric while keeping the latest gauge value; the internal Paimon metric map used by Spark UI remains in place. Local verification: the Spark 3.5 reactor compiled with JDK 8. The `PaimonMetricTest` suite was discovered (11 tests) but aborted before executing because this sandbox denies Spark’s local socket bind (`java.net.SocketException: Operation not permitted`). The PR’s current checks are green (9 successful, 2 skipped), including the Spark CI lane; I did not independently execute the live JMX assertions here. No confirmed blocking issue found. For rollout, please monitor MBean cardinality if an application creates many distinct table names, since the design intentionally retains entries for the JVM lifetime. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
