JingsongLi commented on PR #10141: URL: https://github.com/apache/paimon/pull/10141#issuecomment-5809315420
Requirement fit: SUPPORTED. The one-hour refresh window is a real operational problem for one-hour STS credentials, and the five-minute configurable window has direct end-to-end value. Implementation: CLEAN on the current head (`3cfc7db`). The new shared Python conversion rejects typed negative durations before either RESTTokenFileIO or PVFS uses them, closing my previous finding. I also checked the Java option, serialized window, minimum-validity path, and Python callers; I found no new PR-specific blocker. Verification on this head: `RESTTokenFileIOTest` 16/16 passed; inherited `MockRESTCatalogTest#testRefreshFileIOWhenExpired` 1/1 passed; the two affected Python test files 44/44 passed. The first local Java attempt was blocked by this machine's Mockito self-attachment restriction; rerunning outside that sandbox passed. The Python 3.7 CI job is currently red (31 tests fail with `make_fragment() got an unexpected keyword argument 'file_size'`). That call comes from the recently merged Parquet metadata change on the base branch, outside this PR's diff; the changed token tests passed locally. Please clear or explicitly account for the red required check before merging for production. Other CI jobs were still running when I reviewed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
