lucasfang commented on code in PR #388:
URL: https://github.com/apache/paimon-cpp/pull/388#discussion_r4091170772
##########
src/paimon/common/data/blob_utils.cpp:
##########
@@ -118,12 +132,50 @@ bool BlobUtils::IsMapBlobField(const
std::shared_ptr<arrow::Field>& field) {
return map_type.item_type()->id() == arrow::Type::LARGE_BINARY;
}
-Status BlobUtils::ValidateMapBlobWriteSchema(const
std::shared_ptr<arrow::Schema>& schema) {
+bool BlobUtils::IsBlobFileField(const std::shared_ptr<arrow::Field>& field) {
Review Comment:
IsBlobFileField is easy to confuse with the existing IsBlobField — the two
names differ by a single word yet one is a strict superset of the other, The
name also overloads "blob file", which IsBlobFile(file_name) already uses for
the .blob filename check. Suggest renaming to IsAnyBlobField
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
