hbgstc123 commented on PR #8631: URL: https://github.com/apache/paimon/pull/8631#issuecomment-5811324646
> I don’t think we need to change either ConflictDetection or TableCommitImpl in this PR. > > ConflictDetection already performs DV-aware conflict checking for normal COMPACT commits. The current change only adds a specialized error message based on CommitKind; it does not add any correctness protection. The existing generic conflict error is sufficient, so please remove this change and its test. > > Similarly, exposing filterCommitted through TableCommitImpl is not part of the core commit-message rewriting contract. It is only needed by the stacked engine integration. Please keep the core API unchanged and handle recovery/idempotency in SortCompactCommitter using the existing commit semantics, or discuss a narrowly scoped helper separately in the engine PR. > > This PR should focus on rewriting sort-compact output into CompactIncrement messages and let the existing COMPACT commit path handle validation and conflict detection. Removing these two changes will keep the core PR smaller and avoid unnecessary changes to the commit surface. Addressed in the latest commits. - Removed the CommitKind-specific message in ConflictDetection and testCompactDeletionConflictWithDvHasActionableMessage. COMPACT commits still use the existing DV-aware conflict checks and fail with "File deletion conflicts detected! Give up committing." - Removed TableCommitImpl.filterCommitted. filterAndCommitMultiple is unchanged and still calls FileStoreCommit.filterCommitted. Recovery stays in the engine follow-up (#9790). SortCompactCommitter opens a short-lived FileStoreCommit for the same commit user and calls filterCommitted before rewrite, so already-committed identifiers are dropped without persisting new deletion-vector index files. That path still runs CommitCallback.retry and honors commit.strict-mode.last-safe-snapshot. The temporary commit is closed before rewrite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
