JingsongLi commented on PR #9660: URL: https://github.com/apache/paimon/pull/9660#issuecomment-5831276431
Reviewed head `ef566eecf9` end to end. Requirement fit: SUPPORTED. Implementation: CLEAN in the inspected paths. The opt-in Parquet row-group copy path has a concrete compaction benefit. I checked eligibility and fallback, copied footer and value-stat handling, output cleanup, and the writer metric lifecycle. The previous metric-group leak is fixed: registration is conditional on the option, close propagates to the group, and both behaviors have focused regressions. Verification on JDK 8 / Maven 3.9.9: `mvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -DwildcardSuites=none -Dtest=ParquetFastPathCompactRewriterTest,SimpleStatsMergerTest,AppendOnlyTableCompactionTest,CompactionFastPathMetricsTest test` passed: 35 tests, 0 failures. This includes actual copied Parquet row groups, table scan and predicate cases, stats merging, fallback, and metric lifecycle. `git diff --check` passed. The current CI run has one failure in `S3FileIOTest`: Testcontainers could not pull the unrelated `quay.io/minio/minio:RELEASE.2022-02-07T08-17-33Z` image; other jobs remain in progress. Please ensure the affected CI jobs complete and the S3 infrastructure failure is resolved or rerun before merge. I did not independently rerun a production object-store benchmark or fault-injection campaign. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
