JingsongLi commented on code in PR #955:
URL: https://github.com/apache/paimon-rust/pull/955#discussion_r4103926855
##########
crates/paimon/src/table/kv_file_writer.rs:
##########
@@ -832,7 +838,14 @@ impl KeyValueFileWriter {
end += 1;
}
let group = rows[start..end].iter().collect::<Vec<_>>();
- merged.push(merge.merge_ordered(&group, &buffers, &output_indices,
&output_schema)?);
+ let (row, delete) =
+ merge.merge_ordered(&group, &buffers, &output_indices,
&output_schema)?;
+ merged.push(row);
+ merged_kinds.push(if delete {
+ RowKind::Delete as i8
+ } else {
+ RowKind::Insert as i8
Review Comment:
Fixed in b986893. Both write-buffer merge paths now pass through singleton
rows with their original RowKind, payload, and sequence. Added persisted
cross-commit regressions for product, collect, and partial-update sum.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
