JingsongLi commented on PR #10092: URL: https://github.com/apache/paimon/pull/10092#issuecomment-5832547189
Reviewed head `8c972df` for production. This is test-only, but it protects a distinct end-to-end failure mode of the production `rewrite_file_index` fix already on master: a file written with `[k, a, v]` is rewritten after dropping `a`, leaving the file's `v` position beyond the current schema arity. The test creates and commits a real table file, performs the schema change, runs the index processor, and checks that a `v` sidecar is produced. That is useful regression coverage for a user-visible rewrite failure, so I recommend keeping the PR open. Local `FileIndexProcessorTest` passed 4/4 and `git diff --check` passed. Spark, Flink, and E2E CI pass; both Core CI jobs failed only because `S3FileIOTest` could not pull its MinIO Docker image, so those jobs need a rerun. Optional test strengthening: read the bloom payload and assert membership for the original `v` values, rather than checking only the index key. No code blocker found. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
