XiaoHongbo-Hope commented on code in PR #936:
URL: https://github.com/apache/paimon-rust/pull/936#discussion_r4110400299


##########
docs/src/getting-started.md:
##########
@@ -276,6 +276,17 @@ refreshes those credentials before expiration, so callers 
do not need to load
 the table again. Static `dlf.access-key-id`, `dlf.access-key-secret`, and
 `dlf.security-token` values are not rotated.
 
+To read credentials managed by another process, use a local token file:
+
+```rust
+options.set(CatalogOptions::DLF_TOKEN_LOADER, "local_file");
+options.set(CatalogOptions::DLF_TOKEN_PATH, "/path/to/token.json");
+```
+
+The JSON uses `AccessKeyId`, `AccessKeySecret`, optional `SecurityToken`, and
+optional `Expiration` or `ExpirationAt`. Expiring credentials are reloaded from
+the file before expiration.

Review Comment:
   > @XiaoHongbo-Hope Checked: ECS metadata only returns `Expiration`, and 
PyPaimon never produces an `ExpirationAt`-only payload (it always comes with 
`Expiration`, which wins on read). Nothing relies on it, so let's drop it: 
make`expiration_at_millis` `#[serde(skip)]`, derived from `Expiration` only, 
same as Java.
   
   Thanks @plusplusjiajia . I drop it in the json and create a PR to fix python 
too. https://github.com/apache/paimon/pull/10186



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to