jackylee-ch opened a new pull request, #10191:
URL: https://github.com/apache/paimon/pull/10191
## Purpose
`FileSystemCatalog` and `JdbcCatalog` reject `auto-create` in `create_table`
(pypaimon creates the table eagerly; lazy auto-create is unsupported), but
the
guard is `if schema.options.get("auto-create"):`. The option value is the
string `"false"`, which is truthy in Python, so an explicit and perfectly
legal `auto-create=false` (the default) is hard-rejected with
`property should be False`.
## Change
- Parse the option with `OptionsUtils.convert_to_boolean` and only reject
when
it is actually true, in both catalogs. `false` / `0` / `no` / `off` and an
absent option now pass; `true` / `1` / `yes` / `on` still raise.
## Tests
- `create_table` with `auto-create=false` succeeds and writes the schema;
`auto-create=true` still raises. Verified non-vacuous (without the fix the
false case raises `property should be False`).
Written with Claude Code; verification is mine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
