LuciferYang opened a new pull request, #10215:
URL: https://github.com/apache/paimon/pull/10215

   ### Purpose
   
   The deletion-vector conflict check in `ConflictDetection.checkConflicts` 
wrapped the index-manifest read inside the catch-all around the DV enrichment 
builders. An IO or filesystem failure while reading the index manifest was 
therefore reported as "File deletion conflicts detected! Give up committing.", 
hiding the real cause and pushing the committer toward a needless rollback of a 
valid snapshot.
   
   This reads the index manifest with the IOException-throwing variant outside 
the conflict catch and rethrows IO failures wrapped with the manifest name and 
snapshot id. Only the genuine invariant failures of the DV builders stay 
classified as conflicts.
   
   ### Tests
   
   Added 
`ConflictDetectionTest.testIndexManifestReadFailureIsNotClassifiedAsConflict`: 
it forces the index-manifest read to fail with an IOException and asserts 
`checkConflicts` surfaces a `RuntimeException` naming the manifest read failure 
with the IOException as its root cause, instead of returning a conflict result.
   
   ### API and Format
   
   No.
   
   ### Documentation
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to