LuciferYang opened a new pull request, #10234:
URL: https://github.com/apache/paimon/pull/10234

   ### Purpose
   
   `TagManager.deleteAllTagsOfOneSnapshot` deleted tag files directly without 
calling `TagCallback.notifyDeletion`, unlike the `deleteTag` path used by the 
same expiry loop in `TagBatchCreation`. Tag callbacks such as the Iceberg 
compatibility callback, the success-file callback, and the tag-to-partition 
callback never learned about these deletions and kept metadata for tags that no 
longer exist. This routes the batch deletion through a shared delete-and-notify 
helper and closes the callbacks once after all tags are reported, matching the 
single-tag delete path.
   
   This closes #10233.
   
   ### Tests
   
   Adds `TagManagerTest.testDeleteAllTagsOfOneSnapshotNotifiesCallbacks`, which 
registers a recording `TagCallback`, bulk-deletes both tags of a snapshot that 
still exists, and asserts both tag names are reported to `notifyDeletion`. The 
test fails if the bulk path skips notification.
   
   ### API and Format
   
   No.
   
   ### Documentation
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to