LuciferYang opened a new pull request, #10238:
URL: https://github.com/apache/paimon/pull/10238

   ### Purpose
   
   `FileSystemBranchManager.dropBranch` caught the `IOException` from deleting 
the branch directory, logged it at INFO, and returned normally, so the DDL 
reported success while the branch directory and its data still existed. A later 
create of the same branch name then failed unexpectedly with "already exists".
   
   This rethrows the failure as a `RuntimeException`, the same way the sibling 
`createBranch`, `renameBranch`, and `fastForward` methods in this class already 
do, so the drop-branch DDL fails when the directory cannot be deleted. The 
pre-existing `checkArgument(branchExists(...))` guard is unchanged, so dropping 
a branch that is already absent still surfaces the "doesn't exist" error rather 
than a delete failure.
   
   This closes #10237.
   
   ### Tests
   
   Added `FileSystemBranchManagerTest.testDropBranchFailsWhenDeleteFails`: it 
stubs `FileIO.delete` to throw `IOException`, asserts `dropBranch` rethrows the 
failure, and asserts the branch directory is left in place.
   
   ### API and Format
   
   No.
   
   ### Documentation
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to