LuciferYang opened a new pull request, #10251:
URL: https://github.com/apache/paimon/pull/10251

   ### Purpose
   
   Two fixes in the catalog create/drop path, both reachable via normal DDL on 
filesystem and JDBC catalogs.
   
   Add a default branch to the create-table type dispatch in `AbstractCatalog` 
and `JdbcCatalog`. Without it, a parseable but unsupported type such as 
`lance-table` or `iceberg-table` (enum values that exist for the REST catalog) 
fell through the switch, so `createTable` returned success without creating 
anything and later access failed with table-not-exist. The default now rejects 
the type with `UnsupportedOperationException`.
   
   Trim tokens and skip blanks in `getSchemaExternalPaths`. `dropTable` 
resolved `data-file.external-paths` by splitting the raw string on comma and 
passing each token to `new Path`, while the write side trims. A documented 
multi-value setting with a space after the comma produced a token with a 
leading space and made `new Path` throw, so the table could no longer be 
dropped. Parsing now matches the write side.
   
   This closes #10250.
   
   ### Tests
   
   `FileSystemCatalogTest.testCreateTableWithUnsupportedTypeFailsLoudly`: 
creating a table with type `iceberg-table` now throws 
`UnsupportedOperationException` and the table is not listed.
   
   `FileSystemCatalogTest.testDropTableToleratesBlankExternalPaths`: a table 
whose `data-file.external-paths` has blank and space-padded segments can be 
dropped without error.
   
   ### API and Format
   
   No.
   
   ### Documentation
   
   No.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to