JingsongLi commented on PR #986: URL: https://github.com/apache/paimon-rust/pull/986#issuecomment-5934338632
Requirement fit: **UNSUPPORTED for the stated REST catalog scenario**. Implementation: **CLEAN** at `88e681ba`. The current REST read path is `RESTApi::list_partitions[_paged] -> ListPartitionsResponse -> Partition`, and `Partition::total_buckets` already has `#[serde(default)]` in the base. The modified `PartitionStatistics` is produced and serialized for outbound snapshot commits and partition-registration requests; I found no current production caller that deserializes it. The Rust REST server's commit request carries statistics as a JSON value, and partition listing returns `Partition` as well. I verified this through a real local HTTP request with the new attribute removed: direct `PartitionStatistics` decoding fails as described, while REST partition listing of that same legacy payload already succeeds and returns `total_buckets=0`. The PR's two unit tests pass with the attribute present, but they demonstrate standalone Serde parity rather than an improvement to the claimed end-to-end path. Closing because this PR does not change the stated production behavior. A concrete external consumer that decodes legacy `PartitionStatistics`, or an end-to-end reproducer through an affected production API, would provide a basis to reopen. Java parity for the type is valid; the missing piece is the affected runtime path. Current-main merge-tree and diff check are clean, and all 14 head CI checks are green. Temporary probe edits were restored. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
