JingsongLi commented on PR #10315: URL: https://github.com/apache/paimon/pull/10315#issuecomment-5934638698
Thanks for the contribution. I reviewed the append/primary-key/clustering writers, nested map indexes and index rewriting with historical schemas, and ran `DataFileIndexWriterTest` and `FileIndexProcessorTest` on JDK 8 with the normal Maven checks enabled: all 9 tests passed. The default method preserves existing `FileIndexer` implementations, and I did not identify an implementation regression. The standalone change does not yet deliver the end-to-end lookup benefit described in the motivation. Every production index implementation still uses the default fallback; the only implementation consuming `FileIndexWriterContext` is the recording test plugin. There is no production key-to-file/row-position index, query consumer, or write → commit → indexed lookup test in this PR. Issue #10314 also explicitly scopes this as a building block rather than the lookup implementation. Closing this standalone API extension for now. Please bring the context API back together with a concrete index consumer and tests demonstrating the complete lookup behavior, including compaction/rewrite and failed or retried commits. That will let us review the API against its actual lifecycle requirements and verify the user-visible benefit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
