JingsongLi commented on PR #10282: URL: https://github.com/apache/paimon/pull/10282#issuecomment-5936071127
The two changed deletion paths passed production-oriented review and 44 normal Maven tests across both maintainers and DV serialization/index files. I also verified both merge directions with a position above 2^34, serialized/read the result by its own magic, and checked that the stored input is not modified. One scope limitation for production rollout: the unchanged equal-range fast path in `DataEvolutionCompactDeletionVectorRewriter.moveDeletionVector` still does `newDeletionVector(current option).merge(old)`. It can still reject a stored vector of the opposite width after an option flip. This is an existing compaction limitation, not a regression introduced here; this PR correctly fixes the two deletion paths, but complete bitmap64-option switching with data-evolution compaction needs a follow-up for that path. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
