dev-donghwan commented on PR #10323: URL: https://github.com/apache/paimon/pull/10323#issuecomment-5944432441
Thanks for the review, @JingsongLi! You're right, I overlooked that `findLatest` is on the hot path and the extra `exists` check would cost another IO on every lookup. I've reverted the `findLatest` change and moved the fix into the existing fallback in `latestSnapshotFromFileSystem`. Only when reading the hinted snapshot fails with `FileNotFoundException` and the hint still returns the same id, it now lists the snapshot directory to find the real latest snapshot. If the listing finds no newer snapshot, it still throws as before. So there's no extra IO on the normal path, and the commit path can still recover and rewrite the hint. Could you take another look when you have time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
