JingsongLi commented on PR #10230: URL: https://github.com/apache/paimon/pull/10230#issuecomment-5944653771
Requirement fit: SUPPORTED. Implementation: FINDINGS at `c60393a1c4`. **[P2] Update the downstream Jindo presigning fixture for the new configuration access** `OSSBlobPresigner.java:224` now calls `client.getClientConfiguration().isSLDEnabled()`. The existing `JindoFileIOTest#testCreateBlobPresignedUrlUsesOssClient` also reaches this implementation, but its Mockito `OSSClient` leaves that method unstubbed, returning null. The test now throws an IOException caused by a NullPointerException at this new line. This is the actual failure in both the [JDK 8](https://github.com/apache/paimon/actions/runs/36292649326/job/108545592130) and [JDK 11](https://github.com/apache/paimon/actions/runs/36292649326/job/108545592171) Core/integrations CI jobs. I reproduced the failing Jindo method locally with normal Maven checks. Running the same method with only the presigner implementation restored to the base passes. Please add a `getClientConfiguration()` stub returning `new ClientConfiguration()` to the Jindo fixture, as this PR already does for the OSS fixtures, and rerun the affected CI. This is a test/build regression; real SDK clients have a non-null configuration. The SLD addressing fix has end-to-end value, and its SDK/security contract looks correct. The full `OSSFileIOTest` suite passes all 20 tests locally on both JDK 8 and JDK 11, including actual SDK-signed encoded-key/port URLs and bucket rejection. Production validation still needs the affected integration checks to pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
