jackylee-ch commented on PR #979: URL: https://github.com/apache/paimon-rust/pull/979#issuecomment-5944682954
Addressed. `ensure_no_time_travel_for_write` now includes `SCAN_WATERMARK_OPTION` in its guarded set, alongside the five existing `scan.*` selectors. Since DROP PARTITION calls that guard (as do MERGE/UPDATE/DELETE/INSERT OVERWRITE/TRUNCATE), a write is now rejected while `scan.watermark` is set, so the session can no longer mutate the latest table while its reads resolve a historical snapshot. Regression `test_write_guard_rejects_watermark_selector_including_drop_partition`: on a partitioned table with `SET 'paimon.scan.watermark' = '100'`, both `ALTER TABLE ... DROP PARTITION` and `DELETE` fail with the time-travel error. I verified non-vacuity: removing `scan.watermark` from the guarded set lets both commit and the test fails; with it listed they are rejected. Rebased onto current main. The write-guard tests pass; `clippy -p paimon-datafusion --all-targets --features fulltext,vortex -D warnings` is clean. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
