JingsongLi commented on PR #10194: URL: https://github.com/apache/paimon/pull/10194#issuecomment-5951250353
Local review and actual-file validation did not reveal an unintended implementation regression. The change has end-to-end value: malformed Boolean inputs now follow the configured parse-error policy instead of becoming false silently. Validation at e69e8fe51c: `CsvFileFormatTest` and `JsonFileFormatTest` completed 55 cases (53 passed, 2 existing skips) with normal Maven checks. Additional actual-file probes cover CSV PERMISSIVE/DROPMALFORMED/FAILFAST, strict and error-ignoring JSON, nested Boolean arrays, Boolean map keys/values, and Boolean-map LITERAL writer/read controls. There is one rollout caveat worth making explicit: this also affects `JsonFormatWriter.validateMapNullKeyLiteral`, which uses the changed converter. For `MAP<BOOLEAN,...>` with `json.map-null-key-mode=LITERAL`, an unrecognized literal such as the default `"null"` previously wrote successfully and decoded that key incorrectly as false. It now rejects writing; existing such files throw in strict mode or drop the malformed key when errors are ignored. Canonical true/false output and supported Boolean literals still round-trip. This is consistent with the corruption fix, but users of that configuration need to know about the changed acceptance behavior. The reviewed head also needs a successfully completed Flink 2 CI job before production readiness can be confirmed. Job 108408811671 was canceled after its 120-minute limit; the log has no failing test assertion and the last reported tests pass, but this is not a completed successful suite. Please resolve/rerun that check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
