zhuxiangyi commented on PR #966: URL: https://github.com/apache/paimon-rust/pull/966#issuecomment-5954969668
Thanks! Rebased onto the updated #965 and current main. **[P1] Branch references on automatic expiration.** Fixed by the shared change in #965 (e1d75d2): expiration keeps everything that branches and long-lived changelogs reference, or fails before touching anything. `test_commit_expiration_keeps_branch_files` is your reproduction. With `snapshot.num-retained.min/max = 1`, a plain overwrite expires snapshot 1 on its own; main reads `[2]` and branch b1 still reads `[1]`. **[P2] Ignored empty commits.** Fixed in fd7f163. `maintain()` now also runs on the successful paths that publish nothing: - an empty commit with `ignore-empty-commit`, which is the case you reported; - a dynamic overwrite without data; - an empty `commit_if_latest_snapshot`; - a truncate of no partitions. This matches Java's `expireForEmptyCommit` default. `test_empty_commit_runs_maintenance` follows your probe: three snapshots are written with `write-only`, then maintenance is turned back on and `commit(Vec::new())` leaves `[3]`. It fails without the new call. The persisted-changelog issue you linked is fixed in the shared code as well (see the #965 reply). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
