zhuxiangyi commented on PR #968: URL: https://github.com/apache/paimon-rust/pull/968#issuecomment-5954971036
Thanks for the review! **[P1] Branch references during expiration**: fixed in the shared code in #965 (e1d75d2), which this branch is now rebased onto, together with current main. See the #965 reply for details and tests. **[P2] Writer temporary names**: fixed in 610157d. The snapshot and changelog directories now keep only `snapshot-<id>` / `changelog-<id>` and the hint files. Anything else is a temporary candidate, including the writer's `snapshot-<id>.tmp-<uuid>`. `test_writer_temporary_snapshot_files_are_removed` plants files with the writer's real names (`snapshot-2.tmp-<uuid>`, `LATEST.tmp-<uuid>`, `changelog-2.tmp-<uuid>`). It checks that exactly those are removed while `snapshot-1` and the table data stay. It fails with the old prefix check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
