jackylee-ch commented on PR #10198: URL: https://github.com/apache/paimon/pull/10198#issuecomment-5967280288
Good catch — `laterOrEqualWatermark` stops on whichever equal-watermark snapshot the binary search lands on, so a run sharing the target watermark can resolve to a later member. Rather than change the shared `SnapshotManager` (other callers rely on its current contract), I fix it at this consumption site: after `laterOrEqualWatermark`, the procedure now walks back to the earliest snapshot whose watermark still covers the target, stopping at any gap or missing-watermark snapshot. The tag fallback then runs on that earliest retained id, so the earlier-id-on-tie rule stays consistent. Added a retained repeated-watermark regression alongside the tie/expired-tag one: watermarks `1000,2000,2000,2000,3000`, `watermark => 2000` now tags snapshot 2 (binary search landed on 3). Pushed in 425bc4793. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
