JingsongLi commented on PR #1005:
URL: https://github.com/apache/paimon-rust/pull/1005#issuecomment-5967396705
Requirement fit: **UNSUPPORTED for this standalone version bump**.
Implementation: **FINDINGS** at `802828ef`. Closing this automated update; a
deliberate axum migration should establish its end-to-end need and include the
required source changes.
**[P1] Complete the REST server migration before upgrading axum**
(`crates/paimon-rest-server/Cargo.toml:40`). Both `cargo test --locked -p
paimon-rest-server --all-targets` and `--test e2e` fail to compile:
`RestPath::from_request_parts` at `src/lib.rs:299-303` still uses
`#[async_trait]`, while axum-core 0.5 requires the native future-returning
trait method (E0195). The production server cannot be built.
There is a second startup failure after that compiler error: with only the
obsolete attribute temporarily removed, all 11 real REST-server e2e tests panic
during router construction because `/databases/:db` and the other routes retain
axum 0.7 capture syntax. Axum 0.8 requires `{db}` / `{table}`. The custom
`RestPath` parser must be migrated together with the route patterns so encoded
database/table names still round-trip correctly. See the [upstream migration
changes](https://github.com/tokio-rs/axum/blob/axum-v0.8.9/axum/CHANGELOG.md#080).
Validation: the unmodified head fails compilation; the temporary
compiler-only adjustment exposes 11/11 startup failures. Restoring only the
five PR-changed dependency files to the exact merge base makes all 11 e2e tests
pass. Temporary changes were restored. Dependency-report verification also
fails on stale reports, and head CI has 7 failed jobs and 4 cancellations.
There is no affected Paimon scenario or required security/compatibility change
documented to justify this incomplete migration.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
