jackylee-ch commented on PR #10190: URL: https://github.com/apache/paimon/pull/10190#issuecomment-5968751023
Thanks — you're right that the reader was the real blocker. Fixed it alongside the endpoint change so the OSS read path is actually usable. `FormatVortexReader` built the store with `store.from_url(...)` and then called `vortex_store.open()`, which 0.70.0 object stores don't expose. Switched to the supported entry point, `vortex.open(path, store=...)`, passing the store so it carries the endpoint/credentials while vortex resolves the object; the local-file branch is unchanged. Added a reader test (`format_vortex_reader_test.py`) that drives the remote branch with the real OSS store kwargs from `to_vortex_specified` and a stand-in `vortex` module, asserting the reader opens through `vortex.open(path, store=...)` and never `store.open()` — reverting the fix makes it fail. The SDK boundary is faked so it runs on the Python lane without the native package; the end-to-end OSS read over the wire is validated against the pinned SDK in the native lane (as you did with the HTTPS fixture). Pushed in ef41fa44d. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
