jackylee-ch opened a new pull request, #10355: URL: https://github.com/apache/paimon/pull/10355
### Purpose `snapshot.expire.limit` is "the maximum number of snapshots allowed to expire at a time" (default 50). `ExpireSnapshotsImpl` validates `snapshot.num-retained.min`/`max`, but not this option. A non-positive value (0 is a natural "no limit" guess) makes `maxExclusive = min(maxExclusive, earliest + maxDeletes)` collapse to `earliest`, so the expiration loop never runs: snapshots and their data files are never reclaimed and disk grows unbounded, with no error or log. This rejects a non-positive `snapshot.expire.limit` with a clear message, consistent with the adjacent `retainMin` / `retainMax` checks. ### Tests `ExpireSnapshotsTest#testExpireRejectsNonPositiveLimit`: asserts `expire()` throws `IllegalArgumentException` for limit `0` and `-1`, and that no snapshot is deleted — mirroring `testExpireRejectsNonPositiveRetainMin`. ### API and Format No change. ### Documentation No change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
