leaves12138 commented on code in PR #10368:
URL: https://github.com/apache/paimon/pull/10368#discussion_r4176632024
##########
paimon-python/pypaimon/write/table_write.py:
##########
@@ -344,7 +347,9 @@ def _release_prepared_indexes(self) -> None:
def _prepare_arrow_data(self, data):
self._validate_pyarrow_schema(data.schema)
- return normalize_arrow_strings(data)
+ data = normalize_arrow_strings(data)
+ from pypaimon.write.row_kind import filter_write_batch
+ return filter_write_batch(self.table, data)
Review Comment:
The latest commit only moves `normalize_arrow_strings()` before the filter;
the Python 3.6 regression is still present. The existing
`test_unsupported_nested_cast_fails_before_routing` still constructs a
schema-only `TableWrite` without `table`, while `_prepare_arrow_data()` still
unconditionally evaluates `filter_write_batch(self.table, data)` at this line.
Please fix this path (or update the test double to provide the required table
contract) and rerun the Python 3.6 CI job; the previous failing test will
otherwise still raise `AttributeError` before the expected cast error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
