leaves12138 commented on code in PR #1047:
URL: https://github.com/apache/paimon-rust/pull/1047#discussion_r4195077484
##########
crates/paimon/src/spec/core_options.rs:
##########
@@ -773,6 +773,59 @@ impl<'a> CoreOptions<'a> {
.unwrap_or(false)
}
+ /// Whether a missing optional read target may fall back to the primary
file.
+ pub fn scan_ignore_lost_file(&self) -> bool {
+ self.options
+ .get("scan.ignore-lost-file")
Review Comment:
Java defines this option as `scan.ignore-lost-files` (plural) in
`CoreOptions.SCAN_IGNORE_LOST_FILE`. Reading `scan.ignore-lost-file` here means
a Java-compatible table/read option is ignored, so a missing `.row` sidecar
still fails instead of falling back to the primary file. Please use the plural
key and update the regression tests, which currently also use the singular
spelling.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
