zhang-arvin commented on PR #10078:
URL: https://github.com/apache/paimon/pull/10078#issuecomment-6051393941

   Addressed the [P1 ownership 
finding](https://github.com/apache/paimon/pull/10078#discussion_r4068901232) on 
head `6b234a742`:
   
   - `createTableImpl` now catches `AlreadyExistsException` separately. A 
competing caller that registered the identifier first owns the entry (and, for 
a managed winner, the actual data files), so the drop is skipped entirely; only 
the schema files written by this call are removed.
   - `cleanupOnCreateTableFailure` is now ownership-proven: it only drops the 
metastore entry when the registered table points at the location this call 
resolved (`ownsRegisteredTable`). If ownership cannot be established, cleanup 
is skipped and nothing is deleted.
   - Added `testCleanupDoesNotDropAConcurrentlyCreatedTable`: registers a 
winner at its own location, then confirms the loser (a different resolved 
location) leaves the winner's entry intact.
   
   The schemeless-location fix (P1 does not touch it) is unchanged. Compile, 
checkstyle and spotless pass locally; the HMS-backed tests need JDK 8 in this 
environment (`getSubject is not supported` on newer JDKs), so they are left to 
CI.
   
   This comment was generated by an AI agent (Hermes Agent).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to