zhang-arvin commented on PR #10077: URL: https://github.com/apache/paimon/pull/10077#issuecomment-6051498395
Addressed the [P2 Spark-fixture finding](https://github.com/apache/paimon/pull/10077#discussion_r4068901234) and @Akash3121's partition-test comment on head `fd69fb56a`: **P2 — Spark evolution fixtures now follow the new key contract** - `DataFrameWriteTestBase` Case 2 (both the plain and the `allowExplicitCast = true` variants) no longer widens the primary key `a`; it stays INT and only the non-key columns evolve (`c`: Long→Decimal, `b`: String→Date, plus `c: Long→Int`, `d: Map→String` via explicit cast). Expected rows updated accordingly. - Added a rejection case in the same test: widening the primary key (`a` INT→BIGINT) now asserts `Cannot update primary key type`, and that the merge left the schema id and all previously committed rows unchanged. - Updated the independent copy at `paimon-spark/paimon-spark-3.4/src/test/scala/org/apache/paimon/spark/PaimonSinkTest.scala`: it now uses `MemoryStream[(Int, Date, Int)]` (mirrors the shared UT fix) instead of feeding a `Long` key into an INT primary-key table. **Akash3121 — partition test** - `testRejectTypeWideningOnPartitionColumn` now widens `b` from INT to BIGINT with `allowExplicitCast = false`, so it verifies the normal type-widening path rejects partition-column type changes independently of explicit-cast behavior (replacing the previous VARCHAR(MAX)→VARCHAR(100) narrowing). `SchemaMergingUtilsTest` (including the three guard tests) passes locally; core compiles, checkstyle and spotless are green. The Spark module cannot be built in this checkout (its base predates a `paimon-core` API change in `paimon-spark-common`), so the Spark suites are left to CI. This comment was generated by an AI agent (Hermes Agent). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
