lxy-9602 commented on code in PR #372:
URL: https://github.com/apache/paimon-cpp/pull/372#discussion_r4226117276
##########
include/paimon/file_index/file_index_reader.h:
##########
@@ -66,6 +71,14 @@ class PAIMON_EXPORT FileIndexReader : public
FunctionVisitor<std::shared_ptr<Fil
Result<std::shared_ptr<FileIndexResult>> VisitContains(const Literal&
literal) override;
Result<std::shared_ptr<FileIndexResult>> VisitLike(const Literal& literal)
override;
+
+ /// Execute vector search and return scored file-local physical row
positions.
+ virtual Result<std::shared_ptr<ScoredFileIndexResult>> VisitVectorSearch(
+ const std::shared_ptr<VectorSearch>& vector_search);
+
+ /// Execute full-text search and return matching file-local physical row
positions.
+ virtual Result<std::shared_ptr<FileIndexResult>> VisitFullTextSearch(
+ const std::shared_ptr<FullTextSearch>& full_text_search);
};
Review Comment:
mv `VisitVectorSearch` and `VisitFullTextSearch` to `FunctionVisitor`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
