jianguotian opened a new pull request, #10464:
URL: https://github.com/apache/paimon/pull/10464

   ### Purpose
   
   Fix partition expiration for `DATE` partition columns.
   
   `DATE` values are exposed as epoch-day integers, so `values-time` fails to 
parse an ISO date and skips an eligible partition. Convert non-null `DATE` 
values to `LocalDate` for time extraction, and generate deletion specs with the 
configured partition serializer so metastore cleanup supports both legacy 
epoch-day names and ISO date names.
   
   Preserve existing handling of ordinary `INTEGER` partition values, nulls, 
and empty strings. Document the ISO date representation used for time 
extraction and clarify that `values-time` uses the partition value. No new 
configuration or on-disk layout change is required.
   
   ### Tests
   
   - All 29 focused tests passed with JDK 8: `PartitionExpireTest`, 
`PartitionTimeExtractorTest`, and `PartitionExpireTableTest`.
   - Regression tests cover both `values-time` and `update-time`, legacy and 
ISO partition names, and removal of both table data and registered metastore 
partitions. The legacy-name cases failed before the cleanup fix.
   - Checkstyle, Spotless, configured Maven validation checks, and `git diff 
--check` passed. The tests also passed on the combined tree with upstream 
`master`.
   
   ```bash
   mvn -B -pl paimon-core -am -Pfast-build -DskipTests package
   mvn -B -pl paimon-core -am -DfailIfNoTests=false \
     
-Dtest=PartitionExpireTest,PartitionTimeExtractorTest,PartitionExpireTableTest \
     -DwildcardSuites=none test
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to