JingsongLi commented on PR #10449: URL: https://github.com/apache/paimon/pull/10449#issuecomment-6080498435
Closing under the requested production/end-to-end contribution triage. I traced both walkers to `LicenseChecker.main` and the current artifact-licensing workflow. The checker runs once in an isolated `mvn exec:java ... -N` step; a traversal/filtering exception aborts that step. The proposed try-with-resources change does not change a licensing result, recover the failed check, or address a demonstrated long-lived/repeated caller. Successful exhaustive `Files.walk` traversal already closes its directory iterators. The linked #10138 concerns `Files.list` during sink configuration loading, where resources can remain open after successful loading; that is a different lifecycle. The implementation is straightforward and the 27 `JarFileCheckerTest` / `NoticeFileCheckerTest` tests passed on JDK 8 with standard Maven validation. For this standalone CI failure path, the current evidence supports resource-cleanup hygiene but does not establish an end-to-end production or CI reliability outcome that warrants a separate contribution. A real repeated invocation, recovery path, or failing licensing workload caused by retained directory resources would justify reopening with targeted evidence. Reviewed head: `800b0a2e8bf50e752cecedfd29958dbf5111e677`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
