lszskye commented on code in PR #427:
URL: https://github.com/apache/paimon-cpp/pull/427#discussion_r4246785605
##########
src/paimon/core/utils/blob_view_lookup.cpp:
##########
@@ -150,13 +149,16 @@ Result<BlobViewLookup::DescriptorMapping>
BlobViewLookup::LoadTableDescriptorChu
if (branch) {
return Status::Invalid("do not support upstream table with branch");
}
- auto file_system = catalog_context->file_system;
- PAIMON_ASSIGN_OR_RAISE(std::string table_path,
GetTableLocation(catalog_context, identifier));
+ PAIMON_ASSIGN_OR_RAISE(
+ std::shared_ptr<Catalog> catalog,
+ Catalog::Create(catalog_context->root_path, catalog_context->options,
+ /*file_system=*/nullptr,
catalog_context->fs_scheme_to_identifier_map));
Review Comment:
Could we preserve and propagate the original catalog options when
constructing dependency reads?
WithCatalog() currently only resolves the table’s file system; it does not
copy catalog->GetOptions() into the read context. Catalog options are not
automatically persisted in the table schema either. Therefore, a normal
WithCatalog(rest_catalog, identifier) call does not provide the metastore, URI,
or authentication options needed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
