JingsongLi commented on PR #10493: URL: https://github.com/apache/paimon/pull/10493#issuecomment-6150818497
Requirement fit: SUPPORTED. I found no remaining production logic regression in the floating-key sort/fold, reader comparison, or migration-gate paths at 008294f8dab7b74374c8df867e3f257d34794774. The explicit acknowledgement and migration guide address the historical-file concern. Locally, 202 focused floating-key/type/update tests and 125 merge/sequence/interval/schema tests passed; Flake8 passed. The current CI failure still needs a test-fixture update before this is ready: `ReadBuilderProjectionStateTest.test_variant_read_type_is_shared_by_batch_stream_and_ray_providers` creates an unrestricted Mock table, so the new `check_floating_key_order` sees a truthy Mock `is_primary_key_table` and attempts to iterate a Mock `trimmed_primary_keys_fields`. I reproduced the same TypeError locally. The identical projection test passes when its fixture explicitly declares an append table (`is_primary_key_table=False`, empty trimmed key fields). Please update the fixture to describe the table it is testing and rerun the failed lanes; the production gate should retain its current validation. CI reference: https://github.com/apache/paimon/actions/runs/38370021195/job/115231380291 Rollout remains conditional on stopping older Python writers, validating/rebuilding the relevant historical data and tombstones, then acknowledging and reloading the table as documented. The direct Rust SQLContext API is outside these FileStoreTable gate entry points. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
