JingsongLi commented on PR #10542: URL: https://github.com/apache/paimon/pull/10542#issuecomment-6149512448
Reviewed head bceb68945294f797fac5525904d35510ae43acf8 and ran DeletionVectorTest: all 14 tests passed. The implementation matches the existing equals methods. The contribution still lacks a concrete end-to-end failure. In the current read/write/commit and index paths, deletion vectors and bitmaps are values keyed by file name or business key (for example BucketedDvMaintainer, DeletionVectorsIndexFile, the Spark delta-write merge, and bitmap file indexes); those operations do not hash the bitmap value. The added test demonstrates the general HashSet contract, but does not exercise an affected Paimon operation or establish a user-visible change. Closing under the current review scope, which prioritizes demonstrated end-to-end production value. Please reopen with an actual caller that relies on bitmap/deletion-vector hashing and a reproducer showing the affected query, write, commit, or integration outcome. This is a contribution-value decision, not a claim that the hashCode implementation is incorrect. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
