jianguotian commented on code in PR #10538:
URL: https://github.com/apache/paimon/pull/10538#discussion_r4266499128
##########
paimon-arrow/src/main/java/org/apache/paimon/arrow/vector/ArrowFormatWriter.java:
##########
@@ -261,6 +261,21 @@ public void write(
ColumnVector[] columns, @Nullable int[] pickedInColumn, int
startIndex, int batchRows) {
Preconditions.checkState(rowId == 0, "rowId must be 0 before writing
columns.");
for (int i = 0; i < columns.length; i++) {
+ DataField field = rowType.getFields().get(i);
+ if (!field.type().isNullable()) {
+ for (int j = 0; j < batchRows; j++) {
+ int row =
+ pickedInColumn == null
+ ? startIndex + j
+ : pickedInColumn[startIndex + j];
+ if (columns[i].isNullAt(row)) {
+ throw new IllegalArgumentException(
Review Comment:
> Do we need this?
The new column path bypasses the row writer’s NOT NULL check, so it needs
equivalent validation.
Moved the check to `MosaicRecordsWriter`. Mosaic’s native exception
propagation is fixed upstream, but not in the current 0.2.0 dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
