JingsongLi commented on code in PR #10608:
URL: https://github.com/apache/paimon/pull/10608#discussion_r4294674467
##########
paimon-python/pypaimon/table/row/blob.py:
##########
@@ -672,8 +734,22 @@ def from_descriptor_bytes(
descriptor, file_io=file_io, uri_reader_factory=uri_reader_factory)
@staticmethod
- def from_view(view_struct: BlobViewStruct) -> 'BlobView':
- return BlobView(view_struct)
+ def from_view(*args) -> 'BlobView':
Review Comment:
[P2] Preserve the existing `view_struct` keyword argument
Changing `from_view(view_struct)` to `from_view(*args)` breaks existing
callers using `Blob.from_view(view_struct=BlobViewStruct('db.source', 7, 42))`:
this succeeds on the base but raises `TypeError: Blob.from_view() got an
unexpected keyword argument 'view_struct'` on this head, before a reference can
be written. Please keep accepting the original named parameter while adding the
new forms, and add a compatibility assertion for the keyword call alongside the
positional equivalence checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
