JeonDaehong opened a new pull request, #1160:
URL: https://github.com/apache/paimon-rust/pull/1160

   ### Purpose
   
   Linked issue: close #1159
   
   ### Brief change log
   
   The writer leaves NaN out of FLOAT/DOUBLE min/max, so `max` can't be trusted 
to rule out a NaN row. `>`, `>=`, `NOT BETWEEN`, and `NOT` of `<`, `<=`, 
`BETWEEN` now keep FLOAT/DOUBLE files instead of pruning them by `max`. Same 
idea as #926 did for `NOT(=)`.
   
   The cost is that FLOAT/DOUBLE columns no longer prune on these operators. 
Other types are unchanged.
   
   ### Tests
   
   - `range_predicates_on_float_keep_files_that_may_hold_nan` (unit)
   - `float_nan_stats_pruning_test`: files `[0.0, NaN]` and `[2.0]`, `f > 1.0` 
returned `[2]` before, `[1, 2]` now
   - `equality_exclusion_falls_open_for_floats` (#795) expected `Gt` to keep 
pruning a FLOAT file. Changed that line; `Lt` still prunes.
   
   Ran the ci.yml steps locally (fmt, clippy, msrv, unit, rest-server, 
integration, datafusion, python, go).
   
   ### API and Format
   
   None.
   
   ### Documentation
   
   None.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to