CrownChu commented on PR #10771: URL: https://github.com/apache/paimon/pull/10771#issuecomment-6420553152
@Akash3121 Thanks for the reproduction in [this review](https://github.com/apache/paimon/pull/10771#pullrequestreview-5641466171). Addressed in [8e12fe3cb6](https://github.com/apache/paimon/commit/8e12fe3cb65d6c310260ee8ef6b38ad59192210f). Field coverage cannot establish predicate completeness: `price > 0 AND isNaN(price)` references only `price`, but evaluating the range does not prove that `isNaN` was evaluated. The fix carries an explicit `fullyEvaluated` signal through the evaluator, range evaluation, offset/union readers and query planning. `FilteredRowIdReader.isExact()` now requires that signal in addition to the existing field-coverage and candidate-only checks; completeness alone is not treated as sufficient for exactness. Partial predicates therefore cannot bypass the existing pre-ranking refinement/exclusion rules. Coverage is credited only to groups that actually evaluated the query. BTree index selection is unchanged, and its fused range evaluation is retained. The serialized query format and vector-primary-column design are also unchanged. Added same-field supported/unsupported regressions with real ES archives for both vector and full-text queries, plus framework, wrapper, coverage and BTree regressions. The separate unsupported-keyword-range finding is addressed in the same correctness update and [replied to in its thread](https://github.com/apache/paimon/pull/10771#discussion_r4374056639). This does not add new ESLib query capabilities or upgrade SDK 1.0.7. Validation of the exact committed source: **458 targeted tests passed, 0 failures/errors/skips** (common 56, core 274, ESLib 122, Lumina 6), with a JDK 11 `clean package` reactor build and normal Maven checks enabled (no `fast-build`). This is local targeted validation, not a full repository CI run or cloud E2E result. Please take another look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
