sundapeng commented on PR #1014: URL: https://github.com/apache/paimon-rust/pull/1014#issuecomment-6422962535
Two more commits since my last comment, from a self-review against the same method: - dd16a42: a selective read took the size of its ROW sidecar through the origin operator, while the read of the same sidecar followed the read rule, so with `io-cache.policy=meta,read` every sidecar HEAD stayed on origin. The size request now follows the meta rule like `get_status`; the local size cache keeps its origin-based key. `row_sidecars_of_selective_reads_use_the_target` checks that both the HEAD and the GET reach the target. - 62c44c7: a test only. A branch created from a tag after `ALTER TABLE` changed `data-file.prefix` reads the files it inherited under the earlier prefix through the target, since creating it copied their schemas. A branch whose schema exists only in the catalog cannot read such a file at all (the reader loads the file's schema from the branch's own schema directory first), so no fallback to main's schemas is needed. fmt, clippy and `cargo test -p paimon --all-targets --features fulltext,vortex` pass locally (lib 4741 passed). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
