Akash3121 commented on code in PR #10808:
URL: https://github.com/apache/paimon/pull/10808#discussion_r4383423723
##########
paimon-python/pypaimon/read/table_read.py:
##########
@@ -513,7 +514,10 @@ def to_torch(
):
raise ValueError("batch_size must be a positive int or None")
if batch_format == "row":
- if self.output_projection is not None and
self.output_projection.named:
+ from pypaimon.read.variant_read_type import has_variant_extractions
+
+ if (self.output_projection is not None and
self.output_projection.named
+ and (not streaming or
has_variant_extractions(self.read_type))):
Review Comment:
Nit
Could we update this error message now that named projection expressions are
supported with `streaming=True, batch_format="row"`? For the non-streaming
case, the current text says Torch row format does not support projection
expressions and directs users to `pyarrow` or `torch`, even though simply
enabling streaming row mode is now valid. It may be clearer to use separate
messages for non-streaming named projections and Variant extractions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
