SteNicholas commented on code in PR #467:
URL: https://github.com/apache/paimon-cpp/pull/467#discussion_r4384867758
##########
docs/source/user_guide/write.rst:
##########
@@ -231,7 +231,9 @@ produce a correct ``Snapshot``, which commonly includes
(but is not limited to):
The C++ writer supports Append and PK tables and can produce
``CommitMessage`` objects for both. ``FileStoreCommit`` supports direct
file-system commits for both table types on non-object-store paths.
- Object-store paths require REST catalog commit mode. Changelog is out of
+ Object-store paths require a catalog-mediated commit, configured with either
+ ``CommitContextBuilder::WithCatalog()`` or ``UseRESTCatalogCommit()``;
+ neither needs an atomic rename on the object store. Changelog is out of
Review Comment:
**Require version management for object-store commits.** `WithCatalog()`
alone does not enable object-store commits. `IsCatalogCommit()` requires a
catalog implementing `VersionManagedCatalog` and advertising
`SupportsVersionManagement()`; `FileSystemCatalog` falls back to rename-based
commits and remains rejected on object-store paths. Please qualify this
guidance to require a version-managed catalog, such as REST, so users do not
follow a configuration that still fails.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
