JingsongLi commented on PR #10815:
URL: https://github.com/apache/paimon/pull/10815#issuecomment-6434627204

   Thanks for organizing the cleanup into separate commits. I reviewed all 16 
changed files and checked repository-wide references, service/configuration 
strings, generated-code templates and persistence consumers. The 12 removed 
production types have no current production callers; the remaining changes 
remove their tests and replace a null-coalescing expression in a CDC test 
helper. `GlobalIndexEvaluatorTest` passes locally (36 tests), with the normal 
build checks enabled.
   
   For this production-focused review, the change does not establish a 
caller-visible correctness fix, a runtime performance/resource benefit, or 
another end-to-end outcome beyond deleting currently unused code. Closing this 
cleanup-only PR. A focused change tied to a concrete user/operator problem or 
measured artifact/runtime benefit would give us a specific outcome to evaluate.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to