JTaky commented on PR #10156: URL: https://github.com/apache/paimon/pull/10156#issuecomment-6441920861
> Requirement fit: SUPPORTED. No new implementation regression found after checking the interruption fix and running 189 Core/JDBC/REST/ZooKeeper and Spark 3.4 runtime tests with regular Maven checks. The JDK 8 CI failure I inspected is a Maven Central connection reset resolving scalatest-compatible, rather than a lock test failure. > > Production-boundary note: the session/node checks validate ownership before publication; they do not fence an already in-flight non-atomic object-store publication. With two actual RenamingSnapshotCommit instances and embedded ZooKeeper, I paused A inside simulated non-atomic snapshot publication after validation, expired its session, let B publish snapshot 1, and resumed A. Both returned true, but snapshot 1 contained A, overwriting B. A control checking ownership after the pause rejected A and retained B, but that only moves the window and is not a complete fix for an in-flight write. > > This is the existing finite-lease/publication protocol limitation, not a ZooKeeper-specific regression or a request to add another preflight check. Please keep the safety claim bounded accordingly: loss detected before publication fails visibly; loss during a non-atomic publication still needs storage-side conditional publication/fencing for a stronger guarantee. The PR description currently says the synchronous check runs after the callable, while the current production contract validates before publication. Thanks for the detailed review and reproduction. Agreed: the ownership check runs before publication and does not fence an in-flight non-atomic write after session expiry. We aim for the same lease-based coordination guarantees as JDBC locking, not stronger storage-side fencing. I’ve added this limitation to the documentation. I’ll also correct the PR description’s outdated “after the callable” wording and narrow its safety claims. Rebased onto the latest master and pushed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
