skyyyy955 opened a new pull request, #10840:
URL: https://github.com/apache/paimon/pull/10840

   ### Purpose
   
   Three FileIO tests fail on Windows because they compare LocalFileIO's native 
paths with hard-coded POSIX paths. For example, `file:///tmp/path/to/file.txt` 
produces `\tmp\path\to\file.txt` on Windows, while the test expects 
`/tmp/path/to/file.txt`.
   
   Use `os.path.normpath` for expected local paths and account for the Windows 
drive in `file:///C:/...`. Preserve exact equality checks, the explicit `./` 
prefix, Unicode decoding checks, idempotency, and S3 expectations. This changes 
only three existing test methods; production code is unchanged.
   
   ### Tests
   
   Using baseline `030b38f9948217d0851d29b3583f4f2ee37fd7ed`, pytest 7.4.4 and 
PyArrow 19.0.1:
   
   | Environment | Before | After |
   | --- | --- | --- |
   | Windows, Python 3.10.11 | 28 passed, 3 failed | 31 passed |
   | Linux, Python 3.10.22 | 31 passed | 31 passed |
   
   Both systems ran the complete `pypaimon/tests/file_io_test.py` with 
identical source inputs and no skipped tests. The three Windows failures before 
the change are `test_local_filesystem_path_conversion`, 
`test_windows_path_handling`, and `test_path_normalization`.
   
   Project-configured Flake8 for the changed file, the repository Python 
license-header check, and `git diff --check` pass.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to