lszskye commented on code in PR #461: URL: https://github.com/apache/paimon-cpp/pull/461#discussion_r4409508569
########## src/paimon/common/global_index/scored_global_index_result_utils.h: ########## @@ -0,0 +1,46 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +#pragma once + +#include <cstdint> +#include <memory> +#include <vector> + +#include "paimon/global_index/global_index_result.h" +#include "paimon/result.h" + +namespace paimon { +/// Helpers that combine `ScoredGlobalIndexResult`s. +class ScoredGlobalIndexResultUtils { Review Comment: `scored_global_index_result_utils.cpp` is added to the main library, but paimon_global_index also compiles `union_global_index_reader.cpp`, which now calls ScoredGlobalIndexResultUtils::MergeTopK. Since the helper is not exported, it cannot be resolved from the main shared library, causing non-sanitizer shared builds to fail with an undefined reference to MergeTopK, even without using the new full-text search API. Could you also add `scored_global_index_result_utils.cpp` to the global index library target? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
